[
https://issues.apache.org/jira/browse/TIKA-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082464#comment-17082464
]
ASF GitHub Bot commented on TIKA-3089:
--------------------------------------
pweerd commented on pull request #317: fix for TIKA-3089 contributed by
pvanderweerd
URL: https://github.com/apache/tika/pull/317#discussion_r407574495
##########
File path:
tika-parsers/src/main/java/org/apache/tika/parser/csv/TextAndCSVParser.java
##########
@@ -306,7 +306,6 @@ private CSVParams getOverride(Metadata metadata) {
String delimiterString = mediaType.getParameters().get(DELIMITER);
if (delimiterString == null) {
- return new CSVParams(mediaType, charset);
Review comment:
This removal was unintentional. Apologies for not double checking the diff.
Shall I create a new merge request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Text should be wrapped in pre-tags instead of in p-tags
> -------------------------------------------------------
>
> Key: TIKA-3089
> URL: https://issues.apache.org/jira/browse/TIKA-3089
> Project: Tika
> Issue Type: Improvement
> Components: parser
> Affects Versions: 1.24
> Reporter: Peter van der Weerd
> Priority: Minor
>
> Currently text is treated as normal html, which causes a drama in the
> possible layout. Like, line-endings are not honored, font is not fixed, etc.
>
> By wrapping in pre-tags, the layout will be much better.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
