PeterAlfredLee commented on pull request #332: URL: https://github.com/apache/tika/pull/332#issuecomment-666331912
Hi @THausherr , sorry for the late reply. I think the fix in [TIKA-3135](https://issues.apache.org/jira/browse/TIKA-3135) is trying to avoid occupying the file, therefore we can close it(mostly on Windows). My fix in this PR is trying to make the file deleteOnExit in exception handle, and they will be eventually deleted. Considering they are temp files, I think this fix is reasonable - we do not need to stop the process if exceptions are thrown when deleting temp files. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
