[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295335#comment-17295335
]
Peter Kronenberg commented on TIKA-3310:
----------------------------------------
Yeah, the InputStream stuff is my commit from yesterday, which was already
merged and I don't know why it's showing up again.
I'm not sure that 2 passes would make a difference logically. Either the major
brand matches or one of the compatible brands match, right? That way, if the
major brand doesn't match, it's checking the compatible brands at the same time.
> MP4 video detected as application/mp4
> -------------------------------------
>
> Key: TIKA-3310
> URL: https://issues.apache.org/jira/browse/TIKA-3310
> Project: Tika
> Issue Type: Improvement
> Reporter: Peter Kronenberg
> Priority: Major
> Attachments: sample-movie.mp4
>
>
> The attached file is an MP4 video. When running _new Tika().detect()_ it
> returns _video/quicktime_. But when actually running it through the
> MP4Parser, it returns a very generic _application/mp4_.
>
> Looking at the code, it seems that the generic type comes about because the
> _majorBrand_ of my file is _isom_, which doesn’t match any of the desired
> values, so it defaults to _application/mp4._ Now, I know absolutely nothing
> about mp4 encoding. But looking further, I see there’s a list of
> compatibleBrands, which in my case, includes _mp41_, which would match the
> expected type of _video/mp4_ .
> I coded this up so that if the major brand does not match one of the desired
> values, it checks to see if any of the compatible brands match, and uses the
> first one it finds.
> Is this a proper solution?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
