[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301287#comment-17301287
]
Hudson commented on TIKA-3310:
------------------------------
SUCCESS: Integrated in Jenkins build Tika » tika-main-jdk8 #168 (See
[https://ci-builds.apache.org/job/Tika/job/tika-main-jdk8/168/])
TIKA-3310 Check if MP4 file's compatible brands match any of the expected
values (peter.kronenberg:
[https://github.com/apache/tika/commit/d80dc36531e969a7b4f593bbbe11119f71facbed])
* (edit)
tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-audiovideo-module/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java
TIKA-3310 Check major brand before checking compatible brands
(peter.kronenberg:
[https://github.com/apache/tika/commit/187fd4796b9456bbae244628bcc401ff61c31910])
* (edit)
tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-audiovideo-module/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java
> MP4 video detected as application/mp4
> -------------------------------------
>
> Key: TIKA-3310
> URL: https://issues.apache.org/jira/browse/TIKA-3310
> Project: Tika
> Issue Type: Improvement
> Reporter: Peter Kronenberg
> Priority: Major
> Fix For: 2.0, 1.26
>
> Attachments: sample-movie.mp4
>
>
> The attached file is an MP4 video. When running _new Tika().detect()_ it
> returns _video/quicktime_. But when actually running it through the
> MP4Parser, it returns a very generic _application/mp4_.
>
> Looking at the code, it seems that the generic type comes about because the
> _majorBrand_ of my file is _isom_, which doesn’t match any of the desired
> values, so it defaults to _application/mp4._ Now, I know absolutely nothing
> about mp4 encoding. But looking further, I see there’s a list of
> compatibleBrands, which in my case, includes _mp41_, which would match the
> expected type of _video/mp4_ .
> I coded this up so that if the major brand does not match one of the desired
> values, it checks to see if any of the compatible brands match, and uses the
> first one it finds.
> Is this a proper solution?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
