[
https://issues.apache.org/jira/browse/TIKA-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302060#comment-17302060
]
Hudson commented on TIKA-3313:
------------------------------
FAILURE: Integrated in Jenkins build Tika ยป tika-main-jdk8 #170 (See
[https://ci-builds.apache.org/job/Tika/job/tika-main-jdk8/170/])
TIKA-3313 Improve performance and usability of RereadableInputStream (#413)
(github:
[https://github.com/apache/tika/commit/87f05dee2ec453f2e30fc82d7e3259de8298b6e4])
* (edit)
tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/OOXMLExtractorFactory.java
* (edit)
tika-core/src/main/java/org/apache/tika/utils/RereadableInputStream.java
* (edit)
tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-crypto-module/src/main/java/org/apache/tika/parser/crypto/TSDParser.java
* (edit) tika-core/src/test/java/org/apache/tika/TestRereadableInputStream.java
> Improve performance and usability of RereadableInputStream
> ----------------------------------------------------------
>
> Key: TIKA-3313
> URL: https://issues.apache.org/jira/browse/TIKA-3313
> Project: Tika
> Issue Type: Improvement
> Reporter: Peter Kronenberg
> Priority: Major
> Fix For: 2.0.0
>
>
> I was challenged by the following comment in RereadableInputStream:
> {code:java}
> // TODO: At some point it would be better to replace the current approach
> // (specifying the above) with more automated behavior. The stream could
> // keep the original stream open until EOF was reached. For example, if:
> //
> // the original stream is 10 bytes, and
> // only 2 bytes are read on the first pass
> // rewind() is called
> // 5 bytes are read
> //
> // In this case, this instance gets the first 2 from its store,
> // and the next 3 from the original stream, saving those additional 3
> // bytes in the store. In this way, only the maximum number of bytes
> // ever needed must be saved in the store; unused bytes are never read.
> // The original stream is closed when EOF is reached, or when close()
> // is called, whichever comes first. Using this approach eliminates
> // the need to specify the flag (though makes implementation more
> complex).{code}
> Challenge accepted
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
