tballison commented on a change in pull request #446:
URL: https://github.com/apache/tika/pull/446#discussion_r663130515
##########
File path: tika-core/src/main/java/org/apache/tika/config/ServiceLoader.java
##########
@@ -76,6 +76,11 @@ public ServiceLoader(ClassLoader loader, LoadErrorHandler
handler) {
this(loader, handler, false);
}
+ public ServiceLoader(ClassLoader loader, boolean dynamic) {
+ this(loader, Boolean.getBoolean("org.apache.tika.service.error.warn")
? LoadErrorHandler.WARN :
+ LoadErrorHandler.IGNORE, true);
Review comment:
Should `true` be changed to `dynamic`? Do we need this constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
