[ 
https://issues.apache.org/jira/browse/TIKA-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459670#comment-17459670
 ] 

ASF GitHub Bot commented on TIKA-3327:
--------------------------------------

lewismc commented on a change in pull request #417:
URL: https://github.com/apache/tika/pull/417#discussion_r769277762



##########
File path: 
tika-server/src/main/java/org/apache/tika/server/mbean/ServerStatusExporter.java
##########
@@ -0,0 +1,66 @@
+package org.apache.tika.server.mbean;

Review comment:
       Missing license header?

##########
File path: 
tika-server/src/main/java/org/apache/tika/server/mbean/ServerStatusExporterMBean.java
##########
@@ -0,0 +1,44 @@
+package org.apache.tika.server.mbean;

Review comment:
       Missing license header?

##########
File path: tika-server/src/main/java/org/apache/tika/server/TikaServerCli.java
##########
@@ -70,6 +72,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import javax.management.*;

Review comment:
       I would remove wildcard imports...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Simple server metrics monitoring (server status over JMX)
> ---------------------------------------------------------
>
>                 Key: TIKA-3327
>                 URL: https://issues.apache.org/jira/browse/TIKA-3327
>             Project: Tika
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 2.0.0, 1.25
>            Reporter: Subhajit Das
>            Priority: Minor
>             Fix For: 1.26
>
>
> Currently only  /status endpoint is there as a simple monitoring endpoint. 
> This can not be used directly as part of standard monitoring systems 
> available.
> But no JMX MBeans or any other endpoint is there.
>  
> The status data can be exposed as an MBean.
>  
> This MBean can be then used by, something like Prometheus JMX exporter to 
> export to Prometheus. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to