Konstantin, I trust you implicitly, especially on logging. If you can make this work without breaking anything, please, have at it, unless there are objections from other fellow devs.
The tika-age-recognizer is a dependency disaster, and I think we should mark it as unsupported/deprecated. On Wed, Nov 9, 2022 at 2:45 PM Konstantin Gribov <[email protected]> wrote: > > Hi, folks. > > Currently all Tika source use slf4j API to do the logging and a few test > and cli classes access logging backend directly. That's great. > > Most of the tika-parser-*-module artifacts from standard modules don't > bring any logging deps, some bring commons-logging. > > Not so good news is that some modules like tika-age-recognizer brings > almost all the logging libs that are: logback, commons-logging, log4j 1.2, > reload4j, minlog, logging from jetty-util 6.x, bridges etc. > > All applications bring log4j2-core with log4j-slf4j2-impl with individual > configs in their src/main/resources. > > What I propose is to create new set of modules to wrangle these > dependencies: > > * tika-logging-common with simple SPI to configure root logger logging > level (for tests and applications); > * tika-logging-slf4j-bridges with jul-to-slf4j, jcl-over-slf4j and > log4j-over-slf4j for standard bridge set to allow users easily exclude > bridges and configure them themselves; > * tika-logger-log4j2-impl with log4j-core and log4j-slf4j2-impl, standard > logging config in the resources directory and SPI implementation; > * tika-logger-logback-impl is similar except logback-classic as > implementation and log4j2 -> slf4j bridge, config and SPI implementation. > > I'll prepare initial draft PR for review. > > Any suggestions or ideas? > > -- > Best regards, > Konstantin Gribov
