tballison commented on PR #1345: URL: https://github.com/apache/tika/pull/1345#issuecomment-1723394374
> I was working locally for myself on the migration of Tika from javax to jakarta before I found out this PR and now have a few comments/hints, especially WRT to `tika-parent/pom.xml`: > > 1. The different CXF dependencies could be replaced by the import BOM. > > 2. The same mechanism could be used for SLF4J that also offers a BOM; no need to manage three dependencies. > > 3. On my tests I had to add an exclusion for `xml-apis:xml-apis` in the dependency manangement section for `xerces:xercesImpl`. Otherwise I get tons of errors in my IDE (Eclipse) because the package `org.xml.sax` is accessible from more than one module: `<unnamed>`, `java.xml`. Haven't you seen them too? > > 4. Running `mvn verify` fails in Tika server core: > > > ``` > [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.054 s <<< FAILURE! -- in org.apache.tika.server.core.StackTraceTest > [ERROR] org.apache.tika.server.core.StackTraceTest.testEmptyParser -- Time elapsed: 0.006 s <<< FAILURE! > org.opentest4j.AssertionFailedError: bad type: /tika ==> expected: <200> but was: <500> > at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) > (...) > ``` > Thank you! Adding the above shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
