[
https://issues.apache.org/jira/browse/TIKA-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767589#comment-17767589
]
ASF GitHub Bot commented on TIKA-4137:
--------------------------------------
tballison opened a new pull request, #1350:
URL: https://github.com/apache/tika/pull/1350
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
This PR omits the <title/> element if there is no title. We may want to
insert a space instead? <title> </title>
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)!
Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue
tracker](https://issues.apache.org/jira/projects/TIKA) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square
brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika is successfully built and unit tests pass by running `mvn clean test`
* there should be no conflicts when merging the pull request branch into the
*recent* `main` branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to
relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions
are met. If you have any questions how to fix your problem or about using Tika
in general, please sign up for the [Tika mailing
list](http://tika.apache.org/mail-lists.html). Thanks!
> Building current Tika main branch fails under Java 20/21
> --------------------------------------------------------
>
> Key: TIKA-4137
> URL: https://issues.apache.org/jira/browse/TIKA-4137
> Project: Tika
> Issue Type: Bug
> Components: server
> Affects Versions: 3.0.0-BETA
> Reporter: Thorsten Heit
> Priority: Major
> Attachments: org.apache.tika.server.core.StackTraceOffTest.txt,
> org.apache.tika.server.core.StackTraceTest.txt,
> org.apache.tika.server.core.TikaResourceFetcherTest.txt,
> org.apache.tika.server.core.TikaResourceTest.txt
>
>
> When I execute "mvn verify" on the current main branch using Java 11 or Java
> 17, the build completes. With Java 20 and 21 the same command fails because
> now a couple of JUnit tests in tika-server-core fail:
> {noformat}
> (...)
> [INFO] Running org.apache.tika.server.core.StackTraceTest
> [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.034
> s <<< FAILURE! -- in org.apache.tika.server.core.StackTraceTest
> [ERROR] org.apache.tika.server.core.StackTraceTest.testEmptyParser -- Time
> elapsed: 0.007 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: bad type: /tika ==> expected: <200> but
> was: <500>
> at
> org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
> at
> org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
> at
> org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
> at
> org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
> at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:559)
> at
> org.apache.tika.server.core.StackTraceTest.testEmptyParser(StackTraceTest.java:132)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
> WARN [main] 21:28:26,651 org.apache.tika.pipes.PipesServer received -1 from
> client; shutting down
> ERROR [main] 21:28:26,652 org.apache.tika.pipes.PipesServer exiting: 1
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR] StackTraceOffTest.testEmptyParser:137 bad type: /tika ==> expected:
> <200> but was: <500>
> [ERROR] StackTraceTest.testEmptyParser:132 bad type: /tika ==> expected:
> <200> but was: <500>
> [ERROR]
> TikaResourceFetcherTest.testHeader:101->CXFTestBase.assertContains:66 hello
> world not found in:
> <?xml version="1.0" encoding="UTF-8"?><html
> xmlns="http://www.w3.org/1999/xhtml";>
>
> <head>
>
> <meta name="my-key" content="parsers-value"/>
>
> <meta name="X-TIKA:Parsed-By"
> content="org.apache.tika.parser.DefaultParser"/>
>
> <meta name="X-TIKA:Parsed-By"
> content="org.apache.tika.parser.mock.MockParser"/>
>
> <meta name="author" content="Nikolai Lobachevsky"/>
>
> <meta name="X-TIKA:sourcePath" content="mock/hello_world.xml"/>
> ==> expected: <true> but was: <false>
> [ERROR]
> TikaResourceFetcherTest.testQueryPart:109->CXFTestBase.assertContains:66
> hello world not found in:
> <?xml version="1.0" encoding="UTF-8"?><html
> xmlns="http://www.w3.org/1999/xhtml";>
>
> <head>
>
> <meta name="my-key" content="parsers-value"/>
>
> <meta name="X-TIKA:Parsed-By"
> content="org.apache.tika.parser.DefaultParser"/>
>
> <meta name="X-TIKA:Parsed-By"
> content="org.apache.tika.parser.mock.MockParser"/>
>
> <meta name="author" content="Nikolai Lobachevsky"/>
>
> <meta name="X-TIKA:sourcePath" content="mock/hello_world.xml"/>
> ==> expected: <true> but was: <false>
> [ERROR] TikaResourceTest.testHeaders:91->CXFTestBase.assertContains:66
> <meta name="mymeta" content="first,second,third"/> not found in:
> <?xml version="1.0" encoding="UTF-8"?><html
> xmlns="http://www.w3.org/1999/xhtml";>
>
> <head>
>
> <meta name="my-key" content="parsers-value"/>
>
> <meta name="X-TIKA:Parsed-By"
> content="org.apache.tika.parser.DefaultParser"/>
>
> <meta name="X-TIKA:Parsed-By"
> content="org.apache.tika.parser.mock.MockParser"/>
>
> <meta name="author" content="Nikolai Lobachevsky"/>
>
> <meta name="X-TIKA:digest:SHA1"
> content="R5FG5V2U44YXOZTMKGVNTTSPGLF2JH ==> expected: <true> but was: <false>
> [ERROR]
> TikaResourceTest.testNoWriteLimitOnStreamingWrite:187->CXFTestBase.assertContains:66
> separation.</p> not found in:
> <html xmlns="http://www.w3.org/1999/xhtml";>
> <head>
> <meta name="my-key" content="parsers-value"/>
> <meta name="X-TIKA:Parsed-By"
> content="org.apache.tika.parser.DefaultParser"/>
> <meta name="X-TIKA:Parsed-By"
> content="org.apache.tika.parser.mock.MockParser"/>
> <meta name="author" content="Nikolai Lobachevsky"/>
> <meta name="X-TIKA:digest:SHA1"
> content="AQWEMUMSJVFZWYGM4TKXRTQ5Q436X4DN"/>
> <meta name="Content-Length" content="1562"/>
> <meta name="X ==> expected: <true> but was: <false>
> [INFO]
> [ERROR] Tests run: 75, Failures: 6, Errors: 0, Skipped: 7
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
