[ 
https://issues.apache.org/jira/browse/TIKA-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769876#comment-17769876
 ] 

Maxim Solodovnik commented on TIKA-4139:
----------------------------------------

{quote}Any recs for detecting modules missing these and/or failing the build 
for missing module names?{quote}
I'm not aware of such :(

Maybe I can write some bash script ... :)

I'm afraid I found one more issue with JPMS:

I'm having {{src/main/resources/org/apache/tika/mime/custom-mimetypes.xml}} (As 
recommended here https://tika.apache.org/2.6.0/parser_guide.html)

But this immediately introduces {{org.apache.tika.mime}} package in our jar 
(which is conflicting with same package in Tika ... :((( )

Maybe it worth to create some alternative way to implement this?

Like
* Something like MimeTypesFactory.CUSTOM_MIMES_SYS_PROP but pointing to 
resource on classpath?
* Extendable static Map at MimeTypesFactory?
* Some sort of Service Locator?
* something better than above? :)))

Shall I create new JIRA?


> Tika modules are not JPMS friendly
> ----------------------------------
>
>                 Key: TIKA-4139
>                 URL: https://issues.apache.org/jira/browse/TIKA-4139
>             Project: Tika
>          Issue Type: Improvement
>    Affects Versions: 2.9.0
>            Reporter: Maxim Solodovnik
>            Priority: Major
>             Fix For: 3.0.0-BETA
>
>
> Hello,
> Tika-3 has some major changes, let's add some more :)
> Recently I got following warning while trying to use Tika in JPMS web 
> application:
> {code}
> [INFO] --- compiler:3.11.0:compile (default-compile) @ openmeetings-util ---
> [WARNING] Can't extract module name from 
> tika-parsers-standard-package-2.9.0.jar: tika.parsers.standard.package: 
> Invalid module name: 'package' is not a Java identifier
> {code}
> I've checked {code}main{code} branch and find no {{module-info.java}} and 
> {{Automatic-Module-Name}} also doesn't set.
> Maybe {{Automatic-Module-Name}} can be added to Tika modules?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to