tballison commented on code in PR #1556: URL: https://github.com/apache/tika/pull/1556#discussion_r1463871190
########## tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java: ########## Review Comment: Better not to include the whitespace changes unrelated to the javascript issue. No need to modify, though. I'm guilty of this too occasionally. LOL... Same goes for the improvements to the minShouldMatch tests ########## README.md: ########## @@ -20,7 +20,7 @@ Tika jars can be fetched from Maven Central or your favourite Maven mirror. **Tika 1.X reached End of Life (EOL) on September 30, 2022.** -Tika is based on **Java 8** and uses the [Maven 3](https://maven.apache.org) build system. +Tika is based on **Java 11** and uses the [Maven 3](https://maven.apache.org) build system. Review Comment: Probably better in a separate commit, but let's leave it. Same goes for other improvements in this file. ########## tika-core/src/test/java/org/apache/tika/mime/ProbabilisticMimeDetectionTest.java: ########## @@ -135,7 +136,7 @@ private void testFile(String expected, String filename) throws IOException { private void testStream(String expected, String urlOrFileName, InputStream in) throws IOException { - assertNotNull("Test stream: [" + urlOrFileName + "] is null!", in); + assertNotNull(in, "Test stream: [" + urlOrFileName + "] is null!"); Review Comment: This is a bug which we'll fix in main separately. Let's revert this here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
