[
https://issues.apache.org/jira/browse/TIKA-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830598#comment-17830598
]
ASF GitHub Bot commented on TIKA-4220:
--------------------------------------
tballison opened a new pull request, #1687:
URL: https://github.com/apache/tika/pull/1687
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)!
Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue
tracker](https://issues.apache.org/jira/projects/TIKA) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square
brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika is successfully built and unit tests pass by running `mvn clean test`
* there should be no conflicts when merging the pull request branch into the
*recent* `main` branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to
relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions
are met. If you have any questions how to fix your problem or about using Tika
in general, please sign up for the [Tika mailing
list](http://tika.apache.org/mail-lists.html). Thanks!
> Commons-compress too lenient on headless tar detection
> ------------------------------------------------------
>
> Key: TIKA-4220
> URL: https://issues.apache.org/jira/browse/TIKA-4220
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Minor
>
> On recent regression tests on TIKA-4218, we noticed a fairly major change
> with an increased rate of false positives on headless tar detection from
> commons-compress.
> I think for now we should copy/paste/fork the headless tar detection and
> improve it/revert it or possibly remove it for our 2.9.2 release.
> On this ticket, I'll look into what changed recently in headless tar
> detection in commons-compress and experiment with fixing it.
> One challenge is that our magic bytes detection happens _after_ our custom
> detectors, which means that we can't put a low confidence on what comes out
> of our custom detectors and let the magic detection fix it. We could
> implement an x-tar special case, but I really don't like that.
> Let's see what we can do...
> The numbers below represent the number of files identified as A (in tika
> 2.9.1) -> B (in tika-2.9.2-pre-rc1).
> application/octet-stream -> application/x-tar 826
> multipart/appledouble -> application/x-tar 701
> image/x-tga -> application/x-tar 322
> image/vnd.microsoft.icon -> application/x-tar 312
> application/vnd.iccprofile -> application/x-tar 221
> video/mp4 -> application/x-tar 177
> audio/mpeg -> application/x-tar 59
> video/x-m4v -> application/x-tar 59
> application/x-font-printer-metric -> application/x-tar 36
> audio/mp4 -> application/x-tar 25
> application/x-tex-tfm -> application/x-tar 18
> image/x-pict -> application/x-tar 15
> image/png -> application/x-tar 8
> text/plain; charset=ISO-8859-1 -> application/x-tar 8
> application/x-endnote-style -> application/x-tar 7
> application/x-font-ttf -> application/x-tar 6
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
