yoavhhh opened a new pull request, #2254:
URL: https://github.com/apache/tika/pull/2254
This commit introduces a new Tika parser and detector for NTFS (New
Technology File System) image files.
Key changes:
- Added `tika-parser-ntfs-module` to house the new components.
- `NTFSDetector`: Implements `org.apache.tika.detect.Detector` and
identifies NTFS images by looking for the "NTFS" signature at offset 0x03. It
registers the media type "application/x-ntfs-image".
- `NTFSParser`: Implements `org.apache.tika.parser.AbstractParser` and uses
The Sleuth Kit (`org.sleuthkit.autopsy:core`) to parse NTFS images. It extracts
file system metadata (names, sizes, dates) and file content. It handles
temporary file management for streams and uses `EmbeddedDocumentExtractor` for
file contents.
- Dependencies: Added `org.sleuthkit.autopsy:core` to the new module.
- Registration: Both the parser and detector are registered via
META-INF/services.
- Tests:
- `NTFSDetectorTest`: Includes tests for detecting NTFS images (using a
dummy file with the correct signature) and non-NTFS files.
- `NTFSParserTest`: Includes a smoke test for the parser using the dummy
NTFS image (verifying correct media type detection and handling of SleuthKit
errors on the incomplete image) and a placeholder for tests with a real NTFS
image.
Note: The full build and test cycle for the entire Tika project was
repeatedly timing out in my development environment. While the new module was
built and its tests were structured to pass, a full CI build and test run is
highly recommended to ensure complete integration and catch any latent issues.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)!
Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue
tracker](https://issues.apache.org/jira/projects/TIKA) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square
brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika is successfully built and unit tests pass by running `mvn clean test`
* there should be no conflicts when merging the pull request branch into the
*recent* `main` branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to
relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions
are met. If you have any questions how to fix your problem or about using Tika
in general, please sign up for the [Tika mailing
list](http://tika.apache.org/mail-lists.html). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tika.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
