[ 
https://issues.apache.org/jira/browse/TIKA-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018880#comment-18018880
 ] 

ASF GitHub Bot commented on TIKA-4476:
--------------------------------------

tombrisland commented on PR #2315:
URL: https://github.com/apache/tika/pull/2315#issuecomment-3267289094

   Good spot, I think it can definitely be empty, or at least empty of media 
directories, so definitely worth checking for that.
   
   As for where the call goes - sounds better to do it before and pass it 
through - just a thought:
   
   What do you think about adding the major and compatible brands as metadata 
properties, and then computing the ContentType outside `handleBrands`, either 
in `parse` or `processMp4Directories`? It struck me as a bit odd that it 
happens where it does, as it seems like it could be overwritten by multiple 
metadata directories?




> Audio only MP4 files should be typed audio/mp4
> ----------------------------------------------
>
>                 Key: TIKA-4476
>                 URL: https://issues.apache.org/jira/browse/TIKA-4476
>             Project: Tika
>          Issue Type: Bug
>            Reporter: Tom Brisland
>            Priority: Minor
>
> At present an MP4 container with exclusively audio is still typed as 
> video/mp4.
> Ideally we'd want to categorise these files as audio/mp4 instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to