cstamas commented on code in PR #2390: URL: https://github.com/apache/tika/pull/2390#discussion_r2510794115
########## tika-app/pom.xml: ########## @@ -19,14 +19,13 @@ under the License. --> -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> - <modelVersion>4.0.0</modelVersion> +<project xmlns="http://maven.apache.org/POM/4.1.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd";> + <modelVersion>4.1.0</modelVersion> Review Comment: No need for model version change, Maven 4 is happy with model 4.0 as well. Worth keeping it at model version 4.0 if you want to keep both, ability to build with Maven 3 and Maven 4. Once _only Maven 4 is used_, you can up model as well (of course, if you do want new features and insist on Maven4-only, model change is okay too, but then Maven 3 is not usable anymore to build Tika) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
