nddipiazza commented on PR #1: URL: https://github.com/apache/tika-grpc-docker/pull/1#issuecomment-3693279310
## 🎉 Complete Implementation Summary This PR is now complete with full GPG signed release support and comprehensive development workflow improvements. ### Latest Updates **1. Local Directory Build Support ✅** - Added `-l` option to `build-from-branch.sh` - Build from local tika checkout: `./build-from-branch.sh -l /path/to/tika -t my-build` - Successfully tested with real local tika directory - Container runs successfully with config file **2. Sample Configs Converted to JSON ✅** - All sample configs now available in Tika 4.x JSON format - Converted: grobid, customocr (2 configs), ner, vision (3 configs) - XML files retained for backward compatibility - Successfully tested container startup with JSON config ### Build Options Summary Users now have **three ways** to build tika-grpc Docker images: ```bash # 1. Build from Git branch (remote) ./build-from-branch.sh -b TIKA-4578 # 2. Build from local tika directory (for rapid development) ./build-from-branch.sh -l /home/user/tika -t my-test # 3. Build from GPG-signed release (future - post 4.0.0) ./docker-tool.sh build 4.0.0 4.0.0 ``` ### What's Included ✅ GPG signature verification Dockerfiles (ready for 4.0.0) ✅ Source build Dockerfile (for development) ✅ Local build Dockerfile (for rapid iteration) ✅ Correct JAR artifact name (`tika-grpc` not `tika-server-grpc`) ✅ Sample configs in JSON format for Tika 4.x ✅ Comprehensive documentation ✅ Full alignment with tika-docker approach ### Testing Completed ✅ Built from TIKA-4578 Git branch - SUCCESS ✅ Built from local tika directory - SUCCESS ✅ Container runs with JSON config - SUCCESS ✅ Image size: 737MB (reasonable) ✅ User permissions correct (35002:35002) Ready for review and merge! 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
