[ 
https://issues.apache.org/jira/browse/TIKA-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18048001#comment-18048001
 ] 

ASF GitHub Bot commented on TIKA-4585:
--------------------------------------

nddipiazza commented on PR #2471:
URL: https://github.com/apache/tika/pull/2471#issuecomment-3695917001

   @tballison lgtm. i merged this. 




> Refactor ParseContext to include json configs as a separate map in 4.x
> ----------------------------------------------------------------------
>
>                 Key: TIKA-4585
>                 URL: https://issues.apache.org/jira/browse/TIKA-4585
>             Project: Tika
>          Issue Type: Task
>            Reporter: Tim Allison
>            Priority: Major
>
> We started with using ConfigContainer in ParseContext to hold the json 
> configs where ConfigContainer was a special object. I'm now thinking that we 
> should normalize the json configs as a separate entity within ParseContext. 
> This clarifies the json configs and elevates to more than a hack in tika-core 
> for the sake of this new feature.
> It will require changes throughout to put/get the json directly from the 
> ParseContext and not do the ConfigContainer dance, but the changes are 
> trivial and this adds simplicity to ParseContext and serdes for ParseContext.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to