[ 
https://issues.apache.org/jira/browse/TIKA-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18052085#comment-18052085
 ] 

ASF GitHub Bot commented on TIKA-4618:
--------------------------------------

tballison opened a new pull request, #2533:
URL: https://github.com/apache/tika/pull/2533

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for your contribution to [Apache Tika](https://tika.apache.org/)! 
Your help is appreciated!
   
   Before opening the pull request, please verify that
   * there is an open issue on the [Tika issue 
tracker](https://issues.apache.org/jira/projects/TIKA) which describes the 
problem or the improvement. We cannot accept pull requests without an issue 
because the change wouldn't be listed in the release notes.
   * the issue ID (`TIKA-XXXX`)
     - is referenced in the title of the pull request
     - and placed in front of your commit messages surrounded by square 
brackets (`[TIKA-XXXX] Issue or pull request title`)
   * commits are squashed into a single one (or few commits for larger changes)
   * Tika is successfully built and unit tests pass by running `mvn clean test`
   * there should be no conflicts when merging the pull request branch into the 
*recent* `main` branch. If there are conflicts, please try to rebase the pull 
request branch on top of a freshly pulled `main` branch
   * if you add new module that downstream users will depend upon add it to 
relevant group in `tika-bom/pom.xml`.
   
   We will be able to faster integrate your pull request if these conditions 
are met. If you have any questions how to fix your problem or about using Tika 
in general, please sign up for the [Tika mailing 
list](http://tika.apache.org/mail-lists.html). Thanks!
   




> Improve spooling strategies in 4.x
> ----------------------------------
>
>                 Key: TIKA-4618
>                 URL: https://issues.apache.org/jira/browse/TIKA-4618
>             Project: Tika
>          Issue Type: Task
>            Reporter: Tim Allison
>            Priority: Major
>
> On TIKA-4474, there's a request to spool zip based doc formats. With solid 
> state drives, there just isn't the performance hit that there once was. We'd 
> probably be generally better off spooling "random-access" file formats 
> (zip-based, ole and pdf and ?).
>  
> I'm not sure if we do some simple "pre-detection" step to augment 
> "maybeSpool" in the AutoDetectParser, or maybe we just beef up the detectors 
> and allow configuration there so that the zip detector runs the strategy?
>  
> The idea would be to use the underlying file if it exists. If it doesn't, 
> check that the stream is less than a threshold (default = 100kb?), and if so, 
> don't spool...otherwise spool.
> If anyone has any thoughts on the cleanest design, please offer input.
> cc [~manish003] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to