[
https://issues.apache.org/jira/browse/TIKA-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071578#comment-18071578
]
ASF GitHub Bot commented on TIKA-4704:
--------------------------------------
THausherr commented on code in PR #2746:
URL: https://github.com/apache/tika/pull/2746#discussion_r3042714365
##########
tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServerImpl.java:
##########
@@ -488,5 +488,14 @@ public void shutdown() {
LOG.error("Error shutting down Ignite server", e);
}
}
+ if (pipesClient != null) {
+ LOG.info("Shutting down the pipes client");
+ try {
+ pipesClient.close();
+ }
+ catch (IOException e) {
+ LOG.error("Error closing the pipes client", e);
+ }
+ }
Review Comment:
how about we add a close() or postShutdown() that is package-local and that
does the close of the pipesClient() after server.shutdown().awaitTermination()
has ran?
> Avoid remaining temp files
> --------------------------
>
> Key: TIKA-4704
> URL: https://issues.apache.org/jira/browse/TIKA-4704
> Project: Tika
> Issue Type: Task
> Affects Versions: 3.3.0
> Reporter: Tilman Hausherr
> Priority: Minor
> Fix For: 4.0.0, 3.3.1
>
> Attachments: screenshot-1.png
>
>
> This is my temp directory after a successful build of tika 3. We should try
> to lessen this.
> !screenshot-1.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
