Copilot commented on code in PR #2810: URL: https://github.com/apache/tika/pull/2810#discussion_r3230106518
########## docs/modules/ROOT/pages/maintainers/release-guides/release-artifacts.adoc: ########## @@ -170,9 +170,9 @@ plugins) locally; that build output is the build context for the `apache/tika-grpc` image and isn't published as a release artifact in its own right. -tika-grpc requires at least one pf4j plugin to be loaded at startup; an -empty `plugins/` directory triggers a `TikaConfigException` with a -download URL pointing at Apache dist. +tika-grpc requires at least one pf4j plugin to be loaded at startup; starting +without plugins logs a `LOG.warn` with a download URL pointing at Apache dist. +Fetcher-dependent RPC calls will fail at runtime if no plugins are present. Review Comment: The updated wording still says "tika-grpc requires at least one pf4j plugin to be loaded at startup", but `TikaGrpcServerImpl` explicitly allows an empty plugin set and only logs a warning when `pluginManager.getPlugins().isEmpty()` (server continues to start). Consider rephrasing to something like "tika-grpc expects plugins for full functionality" / "most RPC calls require plugins" and describe that it "logs a warning" (rather than referring to the `LOG.warn` call) to avoid implying startup will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
