[
https://issues.apache.org/jira/browse/TIKA-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18080456#comment-18080456
]
ASF GitHub Bot commented on TIKA-4723:
--------------------------------------
Copilot commented on code in PR #2810:
URL: https://github.com/apache/tika/pull/2810#discussion_r3230106518
##########
docs/modules/ROOT/pages/maintainers/release-guides/release-artifacts.adoc:
##########
@@ -170,9 +170,9 @@ plugins) locally; that build output is the build context
for the
`apache/tika-grpc` image and isn't published as a release artifact in its
own right.
-tika-grpc requires at least one pf4j plugin to be loaded at startup; an
-empty `plugins/` directory triggers a `TikaConfigException` with a
-download URL pointing at Apache dist.
+tika-grpc requires at least one pf4j plugin to be loaded at startup; starting
+without plugins logs a `LOG.warn` with a download URL pointing at Apache dist.
+Fetcher-dependent RPC calls will fail at runtime if no plugins are present.
Review Comment:
The updated wording still says "tika-grpc requires at least one pf4j plugin
to be loaded at startup", but `TikaGrpcServerImpl` explicitly allows an empty
plugin set and only logs a warning when `pluginManager.getPlugins().isEmpty()`
(server continues to start). Consider rephrasing to something like "tika-grpc
expects plugins for full functionality" / "most RPC calls require plugins" and
describe that it "logs a warning" (rather than referring to the `LOG.warn`
call) to avoid implying startup will fail.
> Slim down grpc?
> ---------------
>
> Key: TIKA-4723
> URL: https://issues.apache.org/jira/browse/TIKA-4723
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Major
>
> For 4.0.0-beta, we should figure out if we can slim down tika-grpc mostly
> just for environmental reasons. It currently weighs in at 648MB.
> If we said we only support it in Docker, we could strip out some native libs.
> Other options? Claude, copilot and/or gemini, please help us save the
> environment!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
