Copilot commented on code in PR #2841:
URL: https://github.com/apache/tika/pull/2841#discussion_r3308495688
##########
tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/PerClientServerManager.java:
##########
@@ -270,13 +270,15 @@ private void startServer() throws IOException,
InterruptedException, TimeoutExce
tmpDir = Files.createTempDirectory("pipes-server-" + clientId + "-");
ProcessBuilder pb = new ProcessBuilder(getCommandline());
- // Run the child in tmpDir so any hs_err_pid<N>.log JVM crash log lands
- // where surfaceCrashDiagnostics() looks for it. Redirect stdio to per-
- // server files instead of inheriting the parent JVM's handles -- on
- // Windows inheritIO() duplicates surefire's stderr handle into the
- // child, blocking the controller's pipe reader past parent exit and
- // hanging CI.
- pb.directory(tmpDir.toFile());
+ // Redirect stdio to per-server files instead of inheriting the parent
+ // JVM's handles -- on Windows inheritIO() duplicates surefire's stderr
+ // handle into the child, blocking the controller's pipe reader past
+ // parent exit and hanging CI. We deliberately do NOT call
Review Comment:
The comment mentions “blocking the controller's pipe reader”, but
PerClientServerManager doesn't read from a pipe (it accepts a socket connection
from the child). This wording is misleading; consider rephrasing to the actual
failure mode (duplicated/stuck inherited handles causing hangs in CI).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
