[ 
https://issues.apache.org/jira/browse/TIKA-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18084361#comment-18084361
 ] 

ASF GitHub Bot commented on TIKA-4743:
--------------------------------------

tballison commented on code in PR #2845:
URL: https://github.com/apache/tika/pull/2845#discussion_r3324507680


##########
docs/publish-docs.sh:
##########
@@ -40,12 +40,16 @@ mkdir -p "${DOCS_DIR}"
 
 # Strip the 'tika/' component dir prefix so URLs are /docs/X.Y.Z/...
 cp -r target/site/tika/* "${DOCS_DIR}/"
-# UI assets one level above docs/, since HTML uses ../../_/ relative paths
-cp -r target/site/_/ "${PUBLISH_DIR}/_/"
+# UI assets one level above docs/, since HTML uses ../../_/ relative paths.
+# Replace wholesale: cp -r into an existing directory nests source as a
+# subdirectory (publish/_/_/), so remove first to keep the layout flat.
+rm -rf "${PUBLISH_DIR}/_"
+cp -r target/site/_ "${PUBLISH_DIR}/_"

Review Comment:
   Who doesn't want surprise spring cleaning every once in a while?
   
   But seriously, I think this was more :unamused: than :scream: I've added 
more guards, and I'm grateful for the comment.





> tika-4.0.0-alpha1 - documentation site
> --------------------------------------
>
>                 Key: TIKA-4743
>                 URL: https://issues.apache.org/jira/browse/TIKA-4743
>             Project: Tika
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>            Reporter: Adrian Bird
>            Priority: Minor
>
> A couple of comments about the [Apache Tika Documentation 
> site|https://tika.apache.org/docs/4.0.0-SNAPSHOT/index.html].
>  * I was expecting the menu items on the left to open and show lower level 
> pages where they have a triangle, but they don't. This does make it tricky to 
> navigate because you have to do it via the links on the pages themselves.
>  * Search - trying to use the search feature pops up a small box with the 
> text 'Loading search index...' (in white on the light gray background means 
> it isn't really visible) and nothing happens i.e. no search results are 
> displayed.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to