krickert commented on PR #2921: URL: https://github.com/apache/tika/pull/2921#issuecomment-4907478864
Thanks for the review @nddipiazza, all four points addressed: - e2e tests now exercise the typed contract over a live server (PDF/HTML/embedded DOCX), which flushed out and fixed a real bug: lazy `Property` registry init made typed extra keys degrade to strings in the server JVM. - The `primary == null` branch is now reachable (server passes `null` on empty output) and correctly treats `EMPTY_OUTPUT` as success. - Common field mapping deduped into `TransformSupport.mapCommonFields`. - Renamed `parse_time_ms` to `fetch_parse_time_ms` to match what's actually measured. Also merged latest main (the lombok removal and split-packages changes). Full build plus mapper, grpc, and e2e suites pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
