dschmidt opened a new pull request, #2940:
URL: https://github.com/apache/tika/pull/2940

   JIRA: https://issues.apache.org/jira/browse/TIKA-4780
   
   The MP4 parser already maps the cprt atom to `xmpDM:copyright`; the other
   audio formats dropped the copyright message.
   
   * **MP3:** handle the ID3v2 `TCOP` frame (`TCR` in ID3v2.2), following the
     same pattern as the composer mapping. ID3v1 has no copyright field.
   * **Ogg family (Vorbis/Opus/Speex/FLAC):** map the `COPYRIGHT` comment in
     the shared `OggAudioParser.extractComments`.
   
   On multiple values: Vorbis comments may legally repeat a key (e.g. separate
   "P"- and "C"-line notices), but `xmpDM:copyright` is a single-valued Text
   property, so the first comment is mapped, matching the first-value
   convention of the surrounding mappings. Like the vendor comment, the raw
   values all remain available under the generic `vorbis:copyright` name, so
   the change is purely additive and nothing is dropped.
   
   Testing: the ID3v2.3 and ID3v2.4 fixtures gain a 25-byte `TCOP` frame
   (appended to the tag, audio bytes untouched); assertions added to
   `Mp3ParserTest`, and a new `OggAudioParserTest` covers the shared comment
   mapping including the multiple-comments case.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to