[
https://issues.apache.org/jira/browse/TIKA-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18095955#comment-18095955
]
ASF GitHub Bot commented on TIKA-4784:
--------------------------------------
tballison commented on code in PR #2943:
URL: https://github.com/apache/tika/pull/2943#discussion_r3572631337
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-audiovideo-module/src/main/java/org/apache/tika/parser/mp3/ID3v22Handler.java:
##########
@@ -113,6 +113,13 @@ private ID3Comment getComment(byte[] data, int offset, int
length) {
return ID3v2Frame.getComment(data, offset, length);
}
+ /** Skips null comments (malformed frames) that would trip up consumers. */
+ private void addComment(ID3Comment comment) {
+ if (comment != null) {
+ comments.add(comment);
+ }
+ }
Review Comment:
Lol, y, that's bad.
> Fix ID3v2 text frames unicode handling
> --------------------------------------
>
> Key: TIKA-4784
> URL: https://issues.apache.org/jira/browse/TIKA-4784
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Trivial
>
> An MP3 with a UTF-16 ID3 tag that omits the BOM should not be decoded as
> big-endian
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
