[
https://issues.apache.org/jira/browse/TIKA-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18107525#comment-18107525
]
ASF GitHub Bot commented on TIKA-4838:
--------------------------------------
Copilot commented on code in PR #3062:
URL: https://github.com/apache/tika/pull/3062#discussion_r3846007738
##########
tika-core/src/main/java/org/apache/tika/metadata/Audio.java:
##########
@@ -84,6 +84,15 @@ public interface Audio {
*/
Property BITS_PER_SAMPLE =
Property.internalInteger("audio:bits-per-sample");
+ /**
+ * The audio track's four-character codec identifier from the MP4/QuickTime
+ * sample description (e.g. "mp4a" for AAC, "alac", "ac-3"), or the
protection
+ * scheme ("drms"/"enca") for protected streams, where {@link #HAS_DRM} is
also
+ * set. A per-stream value: with several audio tracks it reflects the last
one.
+ * Distinct from {@link XMPDM#AUDIO_COMPRESSOR}, the human-readable codec
name.
Review Comment:
In this Javadoc, “drms”/“enca” are described as a “protection scheme”, but
elsewhere (e.g., HAS_DRM) they’re treated as protected sample entry formats. To
avoid confusion with the actual protection scheme type carried in a `schm` box
(e.g., `cenc`), consider clarifying the terminology here.
##########
tika-core/src/main/java/org/apache/tika/metadata/Video.java:
##########
@@ -37,4 +37,13 @@ public interface Video {
* reflects the last one.
*/
Property BITRATE = Property.internalInteger("video:bitrate");
+
+ /**
+ * The video track's four-character codec identifier from the MP4/QuickTime
+ * sample description (e.g. "avc1" for H.264, "hvc1"/"hev1" for HEVC), or
the
+ * protection scheme ("encv"/"drmi") for protected streams. A per-stream
value:
+ * with several video tracks it reflects the last one. Distinct from
Review Comment:
This Javadoc calls “encv”/“drmi” a “protection scheme”, but the value being
exposed is the sample-entry type fourcc. Using “protected sample entry format”
here would be more precise and avoids conflating it with the scheme type found
elsewhere in the MP4 protection boxes.
> Expose the MP4 audio and video track codecs (audio:format, video:format)
> ------------------------------------------------------------------------
>
> Key: TIKA-4838
> URL: https://issues.apache.org/jira/browse/TIKA-4838
> Project: Tika
> Issue Type: New Feature
> Reporter: Dominik Schmidt
> Priority: Major
>
> The MP4/QuickTime parser does not expose the per-track codec identifiers.
> TikaMp4SoundHandler and TikaMp4VideoHandler read the sample-entry format
> fourcc but only use it for other purposes (audio: DRM detection; video:
> nothing).
> Add audio:format and video:format, each carrying the four-character codec
> identifier from the track's sample description (audio mp4a/alac/ac-3, video
> avc1/hev1). For protected streams (drms/enca, encv/drmi) the original codec
> is recovered from the nested frma box.
> The existing xmpDM:audioCompressor only fires for audio-typed files and
> carries the container major brand, and xmpDM:videoCompressor carries the
> compressor name (encoder string, e.g. "Lavc… libx264"), so neither gives the
> per-track codec fourcc for video/* files.
> Rounds out the per-track metadata added in TIKA-4779, TIKA-4800 and TIKA-4802.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
