Copilot commented on code in PR #3063:
URL: https://github.com/apache/tika/pull/3063#discussion_r3859844832
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/OOXMLExtractorFactory.java:
##########
@@ -118,6 +124,10 @@ public static void parse(TikaInputStream tis,
ContentHandler baseHandler, Metada
}
metadata.set(HttpHeaders.CONTENT_TYPE, type.toString());
+ if (OOXMLParser.OPC_RELATIONSHIP_TYPES.contains(type)) {
+ markUnreferencedParts(pkg, metadata);
+ }
Review Comment:
`OOXMLParser.SUPPORTED_TYPES` includes `model/vnd.dwfx+xps` (and
`OPCPackageDetector.detectOfficeOpenXML` can return it), but extractor
selection here only treats `vnd.ms-xpsdocument` as XPS. If `type` is
`model/vnd.dwfx+xps`, `coreContentType` will be null and this will fall through
to the "No OOXML extractor found" exception. Consider handling
`model/vnd.dwfx+xps` with `XPSExtractorDecorator` (or removing it from
supported types if it isn't actually supported).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
