dschmidt commented on PR #3044: URL: https://github.com/apache/tika/pull/3044#issuecomment-5435913683
Thanks, that was a genuinely useful pass. I've gone through all of it. The two things worth calling out: the metadata keys are now kebab-cased (`geogebra:app-name` etc., the verbatim attribute names like `toolName` stay), and the component is explicitly named `geogebra-parser`. Both change public surface, so shout if you'd rather have something else before 4.1.0. On the parser, the real bugs were the macro XML overwriting the worksheet metadata and the text expressions dropping anything that wasn't a single literal. Both fixed; for the latter I checked GeoGebra's source and strings are written between plain quotes with no escaping at all, so the `\"` handling was simply wrong and is gone. The rest follows the module conventions now: unreadable or malformed parts are recorded and skipped instead of aborting, `structure.json` only orders the slides that actually exist, the script is a MACRO, pictures are INLINE with their page number, and the detector uses `getEntry()` lookups and sits at the end of the SPI file. One thing I left alone: `ZipFileHelper.open` failing still throws, same as OpenDocumentParser next door. A non-zip named .ggb isn't detected as GeoGebra anyway, so it only bites when the parser is called directly. Streaming detection is now covered by TestContainerAwareDetector. The fixtures are still synthetic though; I'm trying to get hold of a real GeoGebra file with a suitable licence and will add it when I have one. CHANGES is rewritten along your suggestion. The smaller items (bounded JSON reads, thumbnail fallback, leading zeros in slide ids, the hygiene list) are all in, each with a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
