[ 
https://issues.apache.org/jira/browse/TIKA-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18109441#comment-18109441
 ] 

ASF GitHub Bot commented on TIKA-4853:
--------------------------------------

dschmidt commented on code in PR #3092:
URL: https://github.com/apache/tika/pull/3092#discussion_r3886857020


##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-cad-module/src/test/java/org/apache/tika/parser/dwg/DWGParserTest.java:
##########
@@ -276,16 +276,17 @@ public void testDWGReadexe() throws Exception {
         assertNotNull(root.get(DWG.APPLICATION_COMMENT));
         assertContains("AutoCAD", root.get(DWG.PRODUCT_INFO));
 
-        // Thumbnail embedded as INLINE
+        // the THUMBNAILIMAGE section is the drawing's THUMBNAIL embedded 
document

Review Comment:
   Done in 24cbbef8cb (thanks Tilman).





> DWGReadParser emits the drawing thumbnail as INLINE instead of THUMBNAIL
> ------------------------------------------------------------------------
>
>                 Key: TIKA-4853
>                 URL: https://issues.apache.org/jira/browse/TIKA-4853
>             Project: Tika
>          Issue Type: Improvement
>            Reporter: Dominik Schmidt
>            Priority: Major
>
> DWGReadParser extracts the THUMBNAILIMAGE section and emits it as an embedded 
> document named "thumbnail", but with tk:embedded-resource-type=INLINE 
> (DWGReadParser.java:419). It is the drawing's preview image, not a picture 
> placed in the drawing, so it should be THUMBNAIL, consistent with the other 
> container parsers. One-line change plus a test assertion.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to