Copilot commented on code in PR #3100:
URL: https://github.com/apache/tika/pull/3100#discussion_r3891585446
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/geogebra/GeoGebraParser.java:
##########
@@ -301,21 +305,24 @@ private static String stripLeadingZeros(String digits) {
* is set, the document metadata. A part that cannot be read or is not
* well-formed is recorded in the metadata and skipped.
*/
- private void parseGeoGebraXml(ZipFile zipFile, ZipArchiveEntry entry,
- XHTMLContentHandler xhtml, Metadata metadata,
- boolean documentMetadata, ParseContext
context)
+ /**
+ * @return the icon files of the macros in the XML, in document order
+ */
Review Comment:
There are two consecutive Javadoc blocks before parseGeoGebraXml(). Only the
last one will be associated with the method, which makes the earlier
documentation easy to miss and can trigger Javadoc lint noise. Please merge
them into a single Javadoc with both the description and the `@return` tag.
This issue also appears on line 385 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
