dschmidt commented on PR #3107: URL: https://github.com/apache/tika/pull/3107#issuecomment-5482279594
Done: `DefaultPluginsDir` sits in tika-pipes-core next to ConfigMerger, with the probe order (jar dir, its parent for the lib/ layout, cwd) and the absolute-path guarantee in one place, plus the unit tests moved there. TikaServerProcess, PipesForkParser and TikaAsyncCLI/PluginsWriter route through it; their copies are gone. I left tika-grpc out: it has no dependency on tika-pipes-core, and its fallback only runs after a TikaConfigException from a config that named plugin-roots, where guessing a directory the config did not name seems wrong anyway. If you want it covered, the helper could move one level down into tika-plugins-core (grpc already uses TikaPluginManager); happy to do that instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
