dschmidt commented on PR #3090: URL: https://github.com/apache/tika/pull/3090#issuecomment-5482216692
Thanks, that was a useful list. All six are in: 1 was real: extractComments now returns the pictures and FlacParser merges them with the native PICTURE blocks before one emission; testFLAC_commentAndNativePicture.flac (built from the existing fixture) pins one THUMBNAIL for a file carrying both. 2: types beyond the ID3 table count as unknown now, normalized in one place. 3: the javadocs point at CoverArt#thumbnailIndex instead of restating it. 4: a synthetic back-then-front APIC pair in Mp3ParserTest asserts INLINE/THUMBNAIL. 5: readNativePictures got a direct test: a PICTURE block declaring more data than the file has left ends the walk and keeps the earlier pictures. That avoids the vorbis-java tolerance question entirely. 6: one emission lives in CoverArt.extractPictures over a small Picture record; MP3, Ogg and FLAC share it, MP4 spells out its ternary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
