Copilot commented on code in PR #3179:
URL: https://github.com/apache/tika/pull/3179#discussion_r4022176529
##########
tika-pipes/tika-pipes-core/src/main/resources/org/apache/tika/pipes/core/presets/render-thumbnails.json:
##########
@@ -0,0 +1,11 @@
+{
+ // the same first-page and EMF/WMF renders as "thumbnails", added to a full
parse:
+ // text, OCR, embedded documents and everything else stay as the server
configures them
+ "pdf-parser": {
+ "imageStrategy": "RENDER_PAGES_BEFORE_PARSE",
+ "maxRenderedPages": 1,
+ "rendering": {"dpi": 96, "imageType": "RGB"}
+ },
Review Comment:
Applying a preset uses `ParseContext.copyFrom()`, which replaces an existing
JSON entry when the key matches. A server that has a `parse-context`
`pdf-parser` override therefore loses its text/OCR/page settings when this
preset is selected, contradicting the claim that the full parse keeps the
server configuration (the same issue applies to the EMF/WMF entries below).
Merge the component configuration with the server context or explicitly
avoid/clarify this same-key replacement before shipping.
##########
CHANGES.txt:
##########
@@ -1,5 +1,7 @@
Release 4.1.0 - unreleased
+ * New catalog presets, inert until the config names them.(TIKA-4856).
Review Comment:
Add a space before the issue reference; the new release-note sentence
currently reads `names them.(TIKA-4856)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
