[
https://issues.apache.org/jira/browse/TIKA-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18123521#comment-18123521
]
ASF GitHub Bot commented on TIKA-4955:
--------------------------------------
tballison opened a new pull request, #3301:
URL: https://github.com/apache/tika/pull/3301
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)!
Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue
tracker](https://issues.apache.org/jira/projects/TIKA) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square
brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika builds and unit tests pass with `./mvnw clean install` (`clean test`
alone cannot resolve the pipes plugin zips)
* if you used a generative AI tool: follow the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) (`Generated-by:
<tool>` in the commit message), and consider running the pre-flight in
`.skills/devs/pr-review/SKILL.md` — fix what it finds; don't paste its report
here
* there should be no conflicts when merging the pull request branch into the
*recent* `main` branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to
relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions
are met. If you have any questions how to fix your problem or about using Tika
in general, please sign up for the [Tika mailing
list](http://tika.apache.org/mail-lists.html). Thanks!
> tika-bundle-standard: make imports of non-embedded dependencies mandatory
> -------------------------------------------------------------------------
>
> Key: TIKA-4955
> URL: https://issues.apache.org/jira/browse/TIKA-4955
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Minor
>
> All our imports are \{{resolution:=optional}}. A user only finds problems at
> runtime and then with a CNFE. We're asking too much of users.
>
> :robot: proposal:
> {noformat}
> Proposal:
> - Import the packages of every non-embedded dependency used by a
> default-enabled parser or detector with mandatory
> resolution. A missing bundle then fails at resolve time with the package
> named.
> - Set version floors at the versions Tika builds and tests with, not bnd's
> defaults. For example, bnd currently allows
> org.apache.pdfbox [3.0,4) and org.apache.commons.compress [1.28,2).
> - Keep resolution:=optional only for dependencies that are genuinely
> optional at runtime.
> - Add a BundleIT check that instantiates every SPI provider listed in the
> bundle and fails if any provider can't load.
> This catches dependencies that are missing from the embed list.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
