tballison commented on PR #3263:
URL: https://github.com/apache/tika/pull/3263#issuecomment-6023448151
One blocker left. Thank you for your patience.
```
One blocker, otherwise mergeable.
Blocker: per-request config is silently ignored over the wire.
ExecutableParser.parsePE reads the override with
context.get(ExecutableParserConfig.class, defaultConfig). That only sees
an object set programmatically in the same JVM. A
request that sends {"executable-parser": {"extractIcons": false}} to
tika-server or through pipes lands in the
ParseContext as a JSON config keyed by name, which that lookup never
consults, so icons are still extracted and nothing
warns. Every other 4.x parser goes through the resolver that handles both
paths. One-line fix in
ExecutableParser.java:160:
ExecutableParserConfig config = ParseContextConfig.getConfig(
context, "executable-parser", ExecutableParserConfig.class,
defaultConfig);
That resolver also honors the class-keyed override, so the existing
ParseContext test keeps passing. The test that would
catch it is a parse with context.setJsonConfig("executable-parser", ...)
or a server round-trip with the per-request
config.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
