labkey-adam commented on PR #3310: URL: https://github.com/apache/tika/pull/3310#issuecomment-6063756057
Thanks for the fast fix! Completely optional nits, neither blocking: 1. In the test, `assertNull(...)` reads better than `assertEquals(null, ...)`, IMO. 2. A second fixture or case with a `Date:` header that doesn't parse would pin down the intended behavior: no `dcterms:created` at all. That's a small change from 4.1.0, which stored the raw string, but it fits main's TIKA-4917 date handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
