[
https://issues.apache.org/jira/browse/TIKA-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130285#comment-18130285
]
Tim Allison commented on TIKA-4985:
-----------------------------------
[~tilman] This is what claude says about that:
{noformat}
The 60 files under docs/modules/ROOT/examples/ are git symlinks, including
claude-vlm-basic.json. By default, Git for Windows checks a symlink out as a
small text file containing the link's target path. The test's
expected: value is literally that path,
../../../../tika-parsers/tika-parsers-ml/tika-vlm/src/test/resources/config-examples/claude-vlm-basic.json,
so testExamplesMatchTheDocs (VLMConfigExamplesTest.java:128) is
comparing a path string against JSON. This doesn't block the release. It
only affects a Windows checkout that doesn't create real symlinks. Our Windows
CI passed on 721e45dec, so that runner does create real symlinks. I haven't
checked why. What Tilman can do: enable Windows Developer Mode, or use an
elevated shell, so Windows lets ordinary users create symlinks. Then: git
config core.symlinks true
git checkout -- docs/modules/ROOT/examples Or for a one-off build:
-Dtest='!VLMConfigExamplesTest#testExamplesMatchTheDocs' on that module.
{noformat}
I'm going to try to fix this more generally. I don't think you should have to
set core.symlinks to true.
> Prep for 4.2.0 release
> ----------------------
>
> Key: TIKA-4985
> URL: https://issues.apache.org/jira/browse/TIKA-4985
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Major
> Attachments: reports-410g-vs-420b.tgz
>
>
> From the first round: junrar changed exception handling. The updated zip bomb
> detection triggers on compressed log files, and a few other fixes. Vast
> majority of content is unchanged. the mhtml change didn't do much. The html
> detection change is a clear improvement.
>
> Will run round two later today and post results if they're good enough for an
> rc1.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
