Copilot commented on code in PR #3431:
URL: https://github.com/apache/tika/pull/3431#discussion_r4377538291
##########
tika-parsers/tika-parsers-ml/tika-parser-nlp-module/pom.xml:
##########
Review Comment:
Relying on per-dependency exclusions to control JUnit versions can be
brittle (it only fixes this one transitive path). A more robust approach is to
enforce/align JUnit via the parent `dependencyManagement` (and/or an enforcer
rule for dependency convergence), and keep test frameworks as explicit
`test`-scoped dependencies. This reduces the risk of other modules/dependencies
pulling an incompatible JUnit version after the Surefire/Failsafe upgrade.
##########
tika-parent/pom.xml:
##########
@@ -296,9 +296,8 @@
<!-- can't update to 6, needs jdk17 -->
<maven.bundle.version>5.1.9</maven.bundle.version>
<maven.compiler.plugin.version>3.16.0</maven.compiler.plugin.version>
Review Comment:
The previous note about Surefire incompatibility with older JUnit versions
was removed along with the upgrade. If the upgrade is safe because JUnit is now
forced to a compatible version (or older transitive JUnit is excluded),
consider replacing the removed comment with an updated rationale (e.g., which
dependency/version change made 3.6.x viable). This helps prevent future
regressions where an older `junit:junit` re-enters the dependency graph and
breaks the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
