[
https://issues.apache.org/jira/browse/TIKA-5000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132413#comment-18132413
]
ASF GitHub Bot commented on TIKA-5000:
--------------------------------------
Copilot commented on code in PR #3431:
URL: https://github.com/apache/tika/pull/3431#discussion_r4377538291
##########
tika-parsers/tika-parsers-ml/tika-parser-nlp-module/pom.xml:
##########
Review Comment:
Relying on per-dependency exclusions to control JUnit versions can be
brittle (it only fixes this one transitive path). A more robust approach is to
enforce/align JUnit via the parent `dependencyManagement` (and/or an enforcer
rule for dependency convergence), and keep test frameworks as explicit
`test`-scoped dependencies. This reduces the risk of other modules/dependencies
pulling an incompatible JUnit version after the Surefire/Failsafe upgrade.
##########
tika-parent/pom.xml:
##########
@@ -296,9 +296,8 @@
<!
> Can't update 3.0 to surefire 3.6.1
> ----------------------------------
>
> Key: TIKA-5000
> URL: https://issues.apache.org/jira/browse/TIKA-5000
> Project: Tika
> Issue Type: Bug
> Components: build
> Affects Versions: 3.3.3
> Reporter: Tilman Hausherr
> Assignee: Tilman Hausherr
> Priority: Minor
> Fix For: 3.4.0
>
>
> 3.0 builds abort with
> "Surefire is not compatible with JUnit 4.11 or older. Project version is 4."
> After some research, I found this
> https://github.com/apache/drill/issues/3077
> That pointed me to the real problem, which is that JUnit 4 is pulled through
> a dependency.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
