tballison commented on PR #3445:
URL: https://github.com/apache/tika/pull/3445#issuecomment-6453776131
nits from :robot:
```
- No CHANGES.txt row. This relaxes a user-facing config requirement, so it
probably deserves one under 4.2.1.
- Test coverage is uneven. The fetcher gets with-project, without-project
and requires-bucket tests. The emitter and iterator only get without-project.
- Examples still set "projectId": "my-gcp-project" in all four
docs/modules/ROOT/examples/pipes-gcs-*.json files. Dropping it from at least
one would show
it's optional.
```
Only thing that matters to me is the CHANGES.txt. Examples are nice to have,
but not necessary. Test coverage... whatever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
