[ 
https://issues.apache.org/jira/browse/TIKA-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136669#comment-18136669
 ] 

ASF GitHub Bot commented on TIKA-4408:
--------------------------------------

tballison opened a new pull request, #3513:
URL: https://github.com/apache/tika/pull/3513

   …bang; magic '\ ' and '\t' decode to space/tab
   
     The magic decoder turned '\ ' into NUL + space, so ~25 rules never 
matched. Of the
     revived rules, the loose text/x-diff '*** '/'Only in ' and message/rfc822
     'Forward to'/'Pipe to' are dropped, and 'diff ' now needs a '-

> python file identified as application/x-sh under several circumstances
> ----------------------------------------------------------------------
>
>                 Key: TIKA-4408
>                 URL: https://issues.apache.org/jira/browse/TIKA-4408
>             Project: Tika
>          Issue Type: Bug
>          Components: core
>            Reporter: Carol Alexandru
>            Priority: Major
>              Labels: match, mime-type
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> The [definition for text/x-python in 
> tika-mimetypes.xml|https://github.com/apache/tika/blob/25619272d2f615df4ad87e27e7c8dec576f37627/tika-core/src/main/resources/org/apache/tika/mime/tika-mimetypes.xml#L8347]
>  is missing some matches. In particular
>  * #!{+}/usr{+}/bin/env ...
>  * all variants using python{+}3{+} instead of python
> For this reason, a file starting with any of the following valid and fairly 
> common lines are misidentified as application/x-sh (which matches #!/)
> {{#!/usr/bin/env python3}}
> {{#!/usr/bin/env python}}
> {{{}#!{}}}{{{}/usr/bin/python3{}}}
> {{... etc ...}}
> I might do a pull request if I get around to it.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to