[
https://issues.apache.org/jira/browse/TIKA-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137313#comment-18137313
]
ASF GitHub Bot commented on TIKA-5019:
--------------------------------------
tballison opened a new pull request, #3521:
URL: https://github.com/apache/tika/pull/3521
- Retrain the NB model on Wikipedia with ISO-8859-5, -6 and -7 as classes
(34 -> 37); ISO-8859-7 vs windows-1253 is no longer a lenient match.
- Identical candidate decodes report the charset most frequent on
legacy-charset web pages (table from cc-html train consensus).
- BOMDetector: a BOM is a STATISTICAL hint, honored only when the bytes
after it decode in that charset.
- Junk filter keeps the statistical pick when a declaration agrees.
- Mojibuster tolerates UTF-8 errors up to 10% of valid multi-byte
sequences, not counting literal U+FFFD.
- Eval tooling: Wikipedia train/dev/test splits, eval data builder, scorer
and run comparison.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)!
Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue
tracker](https://issues.apache.org/jira/projects/TIKA) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square
brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika builds and unit tests pass with `./mvnw clean install` (`clean test`
alone cannot resolve the pipes plugin zips)
* if you used a generative AI tool: follow the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) (`Generated-by:
<tool>` in the commit message), and consider running the pre-flight in
`.skills/devs/pr-review/SKILL.md` — fix what it finds; don't paste its report
here
* there should be no conflicts when merging the pull request branch into the
*recent* `main` branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to
relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions
are met. If you have any questions how to fix your problem or about using Tika
in general, please sign up for the [Tika mailing
list](http://tika.apache.org/mail-lists.html). Thanks!
> Detecting Arabic encoded with ISO-8859-6 no longer works
> --------------------------------------------------------
>
> Key: TIKA-5019
> URL: https://issues.apache.org/jira/browse/TIKA-5019
> Project: Tika
> Issue Type: Bug
> Components: detector
> Affects Versions: 4.2.0
> Reporter: Boris Petrov
> Priority: Major
>
> I'm upgrading from Tika 3 and this worked fine:
> Groovy code:
> createAndTestFile('جديد للوقاية من العنف وإساءة معاملة الأطفال.',
> Charset.forName('ISO-8859-6')) == 'ISO-8859-6'
> This creates a test file with this text using the specified encoding and then
> uses Tika's DefaultEncodingDetector to detect the charset on it. I explicitly
> used to remove the `UniversalEncodingDetector` because it didn't work OK.
> Otherwise this (and other cases) worked fine.
> With Tika 4 some test cases changed, most are fine but this particularly
> isn't. It returns `x-EUC-TW` instead as the encoding. If I "multiply" the
> string by 20 (that is, copy-paste this text 20 times), then the detector
> returns `windows-1252` - which is also wrong.
> Let me know if you need more information or somehow can't reproduce what I'm
> saying.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
