[
https://issues.apache.org/jira/browse/TIKA-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139078#comment-18139078
]
ASF GitHub Bot commented on TIKA-5037:
--------------------------------------
tballison commented on PR #3531:
URL: https://github.com/apache/tika/pull/3531#issuecomment-6665078874
Bot nits:
```
Edge cases
1. Quadratic string building on hostile input (Notebook.java, the "ename",
"evalue" case in readOutputs). Each
repeat of either key does text = text + ": " + part, which copies the
whole string again. Jackson's streaming
parser allows duplicate keys by default. A crafted output with ~100k
ename keys stays far under the 256 MB
document cap but copies terabytes of string data, so the parse runs
until the timeout kills it. Fix: keep only
the first ename and evalue, or join them with a StringBuilder.
2. docs/modules/ROOT/partials/supported-formats.adoc is not regenerated.
It needs an entry for JupyterParser with
application/x-ipynb+json. TikaCLITest compares that file with
tika-app's generated listing and will fail. CI
hasn't caught it because the PR has merge conflicts, so no checks have
run.
```
> Jupyter notebooks: parse .ipynb, emit the first image output as THUMBNAIL
> -------------------------------------------------------------------------
>
> Key: TIKA-5037
> URL: https://issues.apache.org/jira/browse/TIKA-5037
> Project: Tika
> Issue Type: New Feature
> Components: mime, parser
> Reporter: Dominik Schmidt
> Priority: Major
>
> There is no media type or parser for Jupyter notebooks today;
> shared-mime-info uses {{application/x-ipynb+json}}. A parser could extract
> the cell sources as text, and the cell outputs carry base64 {{image/png}}
> data, the first of which would make a useful THUMBNAIL.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
