dschmidt commented on PR #3536:
URL: https://github.com/apache/tika/pull/3536#issuecomment-6665453481

   Thanks, both addressed in 51dd1f9f1b (and main merged).
   
   1. RAR5 times are now set as instants (`rar.getFormat() == 
RarFormat.RAR50`), RAR4 stays DOS local time. The synthetic RAR5 in the test 
now carries an mtime, parsed under UTC, America/New_York and Asia/Tokyo: 
`2023-11-14T22:13:20Z` in all three; before, it came out zoneless and moved 
with the zone.
   2. Archives are opened with `maxDictionarySize` 1 GB, what WinRAR 5 and 6 
write. There is no test for it: junrar doesn't check the dictionary of stored 
entries, which have no window, and building a compressed RAR5 needs WinRAR. 
Happy to make the cap configurable if you prefer.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to