dschmidt commented on PR #3540:
URL: https://github.com/apache/tika/pull/3540#issuecomment-6666949990

   Thanks, 2 and 3 addressed in the last commit.
   
   2. The record is now matched by the class tag `ff ff`, the name length and 
"CDib", whatever the schema; all 68 files up to SketchUp 2020 that I checked 
use 3, and the javadoc says so. A test also has a stray "CDib" without the 
class tag in front of the real one.
   3. The PNG is read with `readNBytes` and checked against the declared 
length, so a short file declaring 16 MB allocates nothing upfront.
   
   1. I don't have SketchUp, so I can't make a file myself, and the 107 real 
ones I checked (SketchUp 3 to 2026, from public GitHub repositories, still all 
fine after this change) have no license that would let them into the repo. If 
you find redistributable ones in Common Crawl, one per layout would be great.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to