dschmidt commented on PR #3535: URL: https://github.com/apache/tika/pull/3535#issuecomment-6669538731
Thanks, all addressed in the last commit. 1. `@TikaComponent(name = "cr3-parser")`, the name the parser resolves its `ImageMetadataConfig` under. 2. `supported-formats.adoc` is regenerated with `Cr3Parser` / `image/x-canon-cr3`; `testSupportedFormatsPartialIsCurrent` passes. 3. The previews get generated resource names like RawTiffParser's: `thumbnail-0.jpg` for the PRVW preview, `image-0.jpg` for the THMB one. 4. The test now uses `prvw.length + 10`, which runs into mdat; with the box check removed it fails, so it tests what it says. - The test file now has a CMT3 block with a Canon maker note tag (firmware version), checked in the output. - `Cr3AutoDetectTest` in the integration tests parses a minimal CR3 with the full AutoDetectParser and checks that Cr3Parser handles it and the preview comes out as the thumbnail. The 14 real files still give the same metadata, now with the resource names. They're CC0 from raw.pixls.us, but 10 to 60 MB each, so the tests keep building their own file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
