[ 
https://issues.apache.org/jira/browse/TIKA-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137985#comment-18137985
 ] 

ASF GitHub Bot commented on TIKA-5035:
--------------------------------------

dschmidt opened a new pull request, #3527:
URL: https://github.com/apache/tika/pull/3527

   FictionBook names its cover in `<coverpage>` as a reference 
(`xlink:href="#id"`) to one of the base64 `<binary>` elements. 
FictionBookParser emitted every binary without a type, so 
`/unpack/preset/thumbnail` had nothing to serve for an FB2 file.
   
   The parser now remembers the first image referenced from `<coverpage>` and 
marks the binary with that id as `THUMBNAIL`; the other binaries stay as they 
were. Binaries come after the description in an FB2 file, so the reference is 
always known when they are emitted.
   
   Test: in `test.fb2`, `cover.jpg` is the `THUMBNAIL`, the portrait 
`tolstoy_port.png` is untyped. CHANGES entry added.
   
   https://issues.apache.org/jira/browse/TIKA-5035
   




> FictionBook: mark the cover image as THUMBNAIL
> ----------------------------------------------
>
>                 Key: TIKA-5035
>                 URL: https://issues.apache.org/jira/browse/TIKA-5035
>             Project: Tika
>          Issue Type: Improvement
>          Components: parser
>            Reporter: Dominik Schmidt
>            Priority: Major
>
> FB2 names its cover in {{<coverpage>}} as a reference to a base64 
> {{<binary>}}. FictionBookParser emits the binaries but does not mark the 
> cover, so {{/unpack/preset/thumbnail}} has nothing to serve.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to