Antonio Petrelli wrote:
Now I wish to "refactor" all this stuff, but I would like your opinion
on it:
- Rename the <put> element to <putAttribute>, just as the tag name.
+1
- Rename the <add> element to <putAttribute>, and it adds attributes
and not values.
I'm confused. Like Joe, I haven't found much use for the lists, but I
thought that the different between add and put was basically that the
add added a value directly to a list while the put added a new
Attribute. I kind of equated it to a list and a map.
If you rename it to putAttribute, then it will be identical to the
refactor above. In essence aren't you removing this tag instead of
renaming it?
Values are still stored by <item> and <bean> (this
erases the solution for a previous issue that I corrected, gulp!).
?
- Rename <tiles:putList> and <putList> to <tiles:putAttributeList> and
<putAttributeList>, for coherence.
+1
- Remove the "required" clause to the name attribute of
<tiles:insertAttribute>, and add a "value" attribute (with
"rtexprvalue" set) to insert an attribute contained inside an iterated
list attribute value.
Can you explain the use case more? I don't see how we can insert an
attribute which hasn't been named.
Thoughts?
Antonio
